Opened 11 months ago

Closed 11 months ago

Last modified 10 months ago

#7191 closed change (fixed)

Remove unused qunit/common.js file

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-3.5-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, jsonesen Blocked By: #7192
Blocking: #7054 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/23

Description (last modified by kzar)

Background

The adblockpluschrome unit tests include a file qunit/common.js, which contains some common functions. Those functions are no longer being used anywhere, it seems they were somehow leftover from the legacy Firefox extension and its tests.

What to change

  • Remove the qunit/common.js file.
  • Update the buildtools dependency to hg:33f115e8c1b3 git:f02a6f2 to include the required packager changes (see #7192).

Notes

  • I have verified that the builds (chrome, gecko & edge) are not otherwise effected by this buildtools dependency update.

Change History (12)

comment:1 Changed 11 months ago by kzar

  • Description modified (diff)

comment:2 Changed 11 months ago by kzar

  • Ready set

comment:3 Changed 11 months ago by kzar

  • Blocked By 7192 added

comment:4 Changed 11 months ago by kzar

  • Blocked By 7192 removed
  • Description modified (diff)

comment:5 Changed 11 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 11 months ago by kzar

  • Blocked By 7192 added

comment:7 Changed 11 months ago by kzar

  • Description modified (diff)

comment:8 Changed 11 months ago by abpbot

A commit referencing this issue has landed:
Issue 7191 - Remove unused qunit/common.js file

comment:9 follow-up: Changed 11 months ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 in reply to: ↑ 9 Changed 10 months ago by ukacar

Replying to kzar:
Is there anything to test here?

comment:11 Changed 10 months ago by kzar

No, nothing to test here. Sorry, I should have mentioned that in the description.

comment:12 Changed 10 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.