Opened 9 months ago

Closed 9 months ago

#7192 closed change (fixed)

Remove hardcoded qunit/common.js from webpack qunit/tests.js bundle

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: tlucas, sebastian Blocked By:
Blocking: #7191 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/buildtools/merge_requests/1
https://codereview.adblockplus.org/29973555/

Description

Background

We no longer need the adblockpluschrome/qunit/common.js file, but its path is hardcoded in buildtools/packagerChrome.py.

What to change

Modify create_bundles in packagerChrome.py so that qunit/common.js is no longer hardcoded.

Change History (7)

comment:1 Changed 9 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 9 months ago by kzar

  • Blocking 7191 removed

comment:3 Changed 9 months ago by kzar

  • Blocking 7191 added

comment:4 Changed 9 months ago by kzar

  • Review URL(s) modified (diff)

comment:5 Changed 9 months ago by sebastian

  • Priority changed from Unknown to P2
  • Ready set

comment:6 Changed 9 months ago by abpbot

comment:7 Changed 9 months ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.