Opened 9 months ago

Closed 8 months ago

Last modified 8 months ago

#7193 closed change (fixed)

Remove cross-promotion for Adblock Browser from first run page on Microsoft Edge

Reported by: sebastian Assignee: agiammarchi
Priority: P1 Milestone: Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox
Module: User-Interface Keywords:
Cc: geo, Ross, agiammarchi, wspee, greiner Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/186
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/188

Description (last modified by greiner)

Background

Certification of our last (devbuild) submission to the Windows Store failed with following report:

Notes To Developer
The app promotes acquiring software through methods other than the Store.

  1. Upon installation, webpage is opened containing links to download software outside of the Microsoft Store.
  1. Extension window contains links to download software outside of the Microsoft Store.

Apparently Microsoft no longer allows to promote software that is distributed from other sources than the Windows Store. They won't let us publish a new (devbuild or release) version of Adblock Plus as long as we promote Adblock Browser for Android and iOS on the first run page. Note that this is unrelated of EdgeHTML but a Windows Store policy that will remain in effect after they switch to Chromium.

What to change

Hide the cross-promotion for Adblock Browser from the first run page on Microsoft Edge, i.e. info.application == "edge" (not info.platform == "edgehtml").

See also ui#273.

Change History (18)

comment:1 Changed 9 months ago by sebastian

  • Platform changed from Unknown / Cross platform to Edge

comment:2 Changed 8 months ago by agiammarchi

  • Review URL(s) modified (diff)

comment:3 Changed 8 months ago by agiammarchi

Added review URL, this is a no-brainer since the way is the one we already used and tested to avoid showing the issue report button.

comment:4 Changed 8 months ago by agiammarchi

  • Review URL(s) modified (diff)

comment:5 Changed 8 months ago by agiammarchi

Please note there are two different reviews for this, since popup and FRP are different parts of our FE

comment:8 Changed 8 months ago by sebastian

  • Owner set to agiammarchi

comment:9 Changed 8 months ago by sebastian

  • Resolution set to fixed
  • Status changed from new to closed

comment:10 Changed 8 months ago by abpbot

A commit referencing this issue has landed:
Issue 7193 - Fixed popup promotions still being visible

comment:12 Changed 8 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Works as expected.

ABP 0.9.11.2214 (Devbuild)
Edge 44.17763.1.0 / EdgeHTML 18.17763

comment:13 Changed 8 months ago by greiner

  • Description modified (diff)
  • Ready set

Added link to GitLab issue.

comment:14 Changed 8 months ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next

comment:15 Changed 8 months ago by greiner

Does that mean that we can't link to those stores on the first-run page as well as through cross-promotion notifications either? Because if that's the case we'll have to make further changes.

Also note that we only link to adblockplus.org so we could've also left the links in there and instead redirect Edge users to some landing page on adblockplus.org.

comment:16 Changed 8 months ago by sebastian

  • Milestone changed from Adblock-Plus-for-Chrome-Opera-Firefox-next to Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox

comment:17 Changed 8 months ago by saroyanm

For the reference: Andrea also filed a bug report, that can be found here -> https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/20064213/

comment:18 Changed 8 months ago by sebastian

Repeating the report quoted in the the issue description:

The app promotes acquiring software through methods other than the Store.

I don't think that it matters whether clicking the link takes you to a third-party store or a landing page on your own website, or whether you omit the link at all, instructing the user by other means how they get the software. You must not ask users to install software from outside the Windows Store.

We not only removed the cross promotion from the first run page, but also from the browser action popup. As for notifications, we better make sure to not use these on Microsoft Edge in order to cross promote Adblock Browser either. But not sure if that requires changes to the extension, since notifications can target specific browsers.

Note: See TracTickets for help on using tickets.