Opened 8 months ago

Closed 6 months ago

Last modified 3 weeks ago

#7197 closed defect (fixed)

Options page displays General tab when submitting whitelist entry in Edge

Reported by: Ross Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: sebastian, kzar, geo, greiner Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/235

Description (last modified by greiner)

Environment

ABP 0.9.11.2206 (Devbuild)
Edge 42.17134.1.0 / EdgeHTML 17.17134

NOT a regression compared to 0.9.11 (Release)

How to reproduce

  1. Select [ABP Icon] > [Cog].
  2. Select [Whitelist].
  3. Add something to the whitelist (anything).

Observed behaviour

The options page is displays the [General] tab again on submission of a whitelist entry. Checking the [Whitelist] tab shows the entry was added correctly.

Expected behaviour

The options page to not change tab when adding a whitelist entry (to match Chrome and Firefox).

What to change

Explicitly call Event.preventDefault() when executing an action in the desktop options page.

See also ui#347.

Hints for testers

This change affects all keyboard and mouse interactions on the desktop options page.

Change History (8)

comment:1 Changed 6 months ago by greiner

  • Cc greiner added
  • Component changed from Unknown to User-Interface

That sounds like we're not cancelling the "submit" event when submitting the form and thereby causing the frame content to be reloaded. I have yet to verify that assumption though.

comment:2 Changed 6 months ago by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

I found that we implicitly cancel the event by disabling the submit button rather than by explicitly calling preventDefault(). Edge doesn't cancel the event on the former though which is what's causing the difference in behavior.

comment:3 Changed 6 months ago by greiner

  • Description modified (diff)
  • Owner set to greiner

comment:4 Changed 6 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 6 months ago by greiner

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 3 months ago by Ross

This is occurring again in the 3.6 dev builds for Edge. Should I open a ticket on GitLab?

ABP 0.9.15.2335
Edge 44.17763.1.0

Note: See TracTickets for help on using tickets.