Changes between Initial Version and Version 1 of Ticket #7206


Ignore:
Timestamp:
01/10/2019 03:29:37 PM (11 months ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7206

    • Property Priority changed from Unknown to P2
    • Property Ready set
    • Property Component changed from Unknown to Platform
  • Ticket #7206 – Description

    initial v1  
    11=== Environment === 
    2 ABP 0.9.11.2214 (Devbuild) 
     2ABP 0.9.11.2214 (Devbuild), or 0.9.11 (Release) 
    33Edge 44.17763.1.0 / EdgeHTML 18.17763 
    44 
    5 NOT a regression compared to 0.9.11 (Release) 
     5=== How to reproduce === 
     6Intercept and rewrite the request to notification.adblockplus.org using a proxy to return a notification file. 
    67 
    7 === How to reproduce === 
    8  1a. Just after install, set the ABP notificatonurl to a notification.json file/path that actually contains a notification. (This didn't work for me). 
    9  1b. Intercept and rewrite the request to notification.adblockplus.org using a proxy to return a notification file. 
    10  2. Test this notification in Chrome. 
    11  3. Now try this notification in Edge 
     8OR 
     9 
     10Append this snippet to `adblockpluschrome/lib/csp.js`, rebuild and reload the extension, then navigate to `https://example.com`: 
     11 
     12{{{ 
     13require("notification").Notification.addNotification({ 
     14  id: new Date() | 0, 
     15  type: "critical", 
     16  title: "Notification title", 
     17  message: "<a>Open contribution page</a>", 
     18  links: ["contribute"], 
     19  urlFilters: ["||example.com^$document"] 
     20}); 
     21}}} 
    1222 
    1323=== Observed behaviour === 
     
    1727Notifications to not crash the browser. 
    1828 
    19 === Example notification === 
     29=== Notes === 
     30Even simply calling the notification API from the extension's background console crashes Edge consistently! For example, try this snippet: 
     31 
    2032{{{ 
    21 { 
    22   "notifications": [ 
    23     { 
    24       "id": "1", 
    25       "message": { 
    26         "en-US": "Test", 
    27         "de": "German" 
    28       }, 
    29       "severity": "normal", 
    30       "title": { 
    31         "en-US": "Test", 
    32         "de": "German" 
    33       } 
    34     } 
    35   ], 
    36   "version": "201901011538" 
    37 } 
     33chrome.notifications.create({ 
     34  type: "basic", 
     35  iconUrl: "icons/abp-16.png", 
     36  title: "Hello title", 
     37  message: "Hello world", 
     38  isClickable: true, 
     39  buttons: [{title: "CLICK HERE PLEASE"}] 
     40}); 
    3841}}}