Opened 14 months ago

Last modified 14 months ago

#7206 closed defect

Notifications crash Edge — at Initial Version

Reported by: Ross Assignee:
Priority: P2 Milestone: Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox
Module: Platform Keywords: externaldependency
Cc: sebastian, kzar, geo Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/25

Description

Environment

ABP 0.9.11.2214 (Devbuild)
Edge 44.17763.1.0 / EdgeHTML 18.17763

NOT a regression compared to 0.9.11 (Release)

How to reproduce

1a. Just after install, set the ABP notificatonurl to a notification.json file/path that actually contains a notification. (This didn't work for me).
1b. Intercept and rewrite the request to notification.adblockplus.org using a proxy to return a notification file.

  1. Test this notification in Chrome.
  2. Now try this notification in Edge

Observed behaviour

Edge crashes just after ABP makes the request for the notification file. The same notification file works fine in Chrome.

Expected behaviour

Notifications to not crash the browser.

Example notification

{
  "notifications": [
    {
      "id": "1",
      "message": {
        "en-US": "Test",
        "de": "German"
      },
      "severity": "normal",
      "title": {
        "en-US": "Test",
        "de": "German"
      }
    }
  ],
  "version": "201901011538"
}

Change History (0)

Note: See TracTickets for help on using tickets.