Opened 13 months ago

Last modified 12 months ago

#7206 closed defect

Notifications crash Edge — at Version 3

Reported by: Ross Assignee:
Priority: P2 Milestone: Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox
Module: Platform Keywords: externaldependency
Cc: sebastian, kzar, geo Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/25

Description (last modified by kzar)

Environment

ABP 0.9.11.2214 (Devbuild), or 0.9.11 (Release)
Edge 44.17763.1.0 / EdgeHTML 18.17763

How to reproduce

Intercept and rewrite the request to notification.adblockplus.org using a proxy to return a notification file.

OR

Append this snippet to adblockpluschrome/lib/csp.js, rebuild and reload the extension, then navigate to https://example.com:

require("notification").Notification.addNotification({
  id: new Date() | 0,
  type: "critical",
  title: "Notification title",
  message: "<a>Open contribution page</a>",
  links: ["contribute"],
  urlFilters: ["||example.com^$document"]
});

Observed behaviour

Edge crashes just after ABP makes the request for the notification file. The same notification file works fine in Chrome.

Expected behaviour

Notifications to not crash the browser.

Notes

Even simply calling the notification API from the extension's background console crashes Edge consistently! For example, try this snippet:

browser.notifications.create({
  type: "basic",
  iconUrl: "icons/abp-16.png",
  title: "crash test",
  message: "hello world"
});

See the related Microsoft Edge bug report: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/20146233/

Change History (3)

comment:1 Changed 13 months ago by kzar

  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed 13 months ago by kzar

  • Description modified (diff)

comment:3 Changed 13 months ago by kzar

  • Description modified (diff)
  • Keywords externaldependency added

Edge crashes when we use the browser.notifications.create API, it happens with the currently released version of Adblock Plus too. I've reported this to Microsoft, but I don't think this should block our release.

Note: See TracTickets for help on using tickets.