Changes between Initial Version and Version 1 of Ticket #7210


Ignore:
Timestamp:
01/14/2019 12:43:00 AM (9 months ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7210 – Description

    initial v1  
    22In `include.preload.js`, we already keep track of selectors used for element collapsing, in order to avoid injecting the same selector twice. However, we still send a message to the background page for every failed attempt to load an element regardless whether we have seen the resulting selector before. Instead, we could keep tack of all seen selectors (which most of the time will be the same number of selectors we inject), and skip the messaging with the background page altogether for selectors we have seen before. 
    33 
     4That way we also avoid Firefox to run out of memory if a page attempts to reload a resource that failed to load (or was blocked) at a high frequency, see [https://bugzilla.mozilla.org/show_bug.cgi?id=1516508 Firefox bug 1516508]. 
     5 
    46=== What to change === 
    57Keep track of all selectors considered for element collapsing, and don't send more than one `filters.collapse` message for elements that are targeted by an incidental selector.