Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#7212 closed change (fixed)

Ensure migration path from builds for Microsoft Edge to builds for Chromium

Reported by: sebastian Assignee: sebastian
Priority: P2 Milestone: Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: geo, kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/28

Description (last modified by sebastian)

Background

With Microsoft Edge replacing EdgeHTML with Chromium, and consequently the existing extension infrastructure with Chrome extensions, we should make sure that when migrating from the current Adblock Plus for Microsoft Edge to a build for Chromium-based browsers, all data are preserved (assuming that Microsoft Edge will persist the data in storage.local through the update process).

Currently, in the builds for the old Microsoft Edge, we store filter data in IndexedDB (which our builds for Chromium-based browsers are agnostic of). However, starting with #6775 we backup the filter data into storage.local, though using a bogus key (i.e. file:indexedDB-backup), while Adblock Plus for Chrome is only looking for filter data stored with the key file:patterns.ini. If we rename that key accordingly the backup should be picked up after the migration without requiring further changes.

What to change

Store backups written to storage.local on (the old) Microsoft Edge with the key file:patterns.ini.

Hints for testers

Before a preview build of the Chromium-based version of Microsoft Edge becomes available there is no ultimate way to make sure that this will be working as expected. However, you might want to make sure that this change doesn't break #6775. Also see the note in the review, for some improvised test instructions.

Change History (8)

comment:1 Changed 5 months ago by sebastian

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 months ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 5 months ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next

comment:5 Changed 5 months ago by Ross

Should I be able to check this like below in the background console?
browser.storage.local.get("file:patterns.ini").then(console.log);

comment:6 Changed 5 months ago by sebastian

  • Description modified (diff)

I added some hints for testers to the issue description.

comment:7 Changed 5 months ago by sebastian

  • Description modified (diff)

comment:8 Changed 5 months ago by sebastian

  • Milestone changed from Adblock-Plus-for-Chrome-Opera-Firefox-next to Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox
Note: See TracTickets for help on using tickets.