Opened 3 months ago

Last modified 3 months ago

#7215 new defect

Subscription link overlay is hidden if multiple Options pages are open in Edge

Reported by: Ross Assignee:
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: snoack, kzar, geo, greiner Blocked By:
Blocking: Platform: Edge
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by Ross)

Environment

ABP 0.9.11.2216 (Devbuild)
Edge 44.17763.1.0 / EdgeHTML 18.17763

How to reproduce

  1. Install freash Edge build.
  2. Navigate to https://testpages.adblockplus.org/
  3. Select the subscribe button.
  4. Close Options tab.
  5. Select the subscribe button.
  6. Close Options tab.
  7. Select the subscribe button.
  8. Don't close the Options tab.
  9. Repeat Steps 7-8 several times.

Observed behaviour

Steps 3-5:
If no Options page is already open, the Options page opens with the overlay displayed (expected). If the Options page is closed and the steps repeated, the Options page opens with the overlay displayed (expected).

Steps 7-9:
If no Options page is already open, the Options page opens with the overlay displayed (expected).

If the user then switches back without closing the Options page and selects the subscribe link again, another Options page (2nd) is opened but the overlay is not displayed.

If the user then swtiches back again and selects the subscribe link, another Options page (3rd) is opened but without the overlay. However the overlay that was missing from the (2nd) Options page above is then displayed.

Expected behaviour

The add subscription overlay to be visible after the user selects a subscription link.

Attachments (1)

edge-subscription.mp4 (417.5 KB) - added by Ross 3 months ago.

Download all attachments as: .zip

Change History (4)

Changed 3 months ago by Ross

comment:1 Changed 3 months ago by Ross

  • Description modified (diff)

comment:2 Changed 3 months ago by kzar

  • Cc greiner added
  • Component changed from Platform to User-Interface

I think that this will be practically solved once #7216 is fixed and we avoid Edge opening the options page multiple times in the first place. But up to you if you want to have subscription links work correctly when there's multiple instances of the options page open.

comment:3 Changed 3 months ago by greiner

I agree that there's no need to fix this issue if the scenario causing it can't be reproduced. Therefore I'd say let's wait until #7216 is done and then close this issue if we can no longer reproduce it.

We can always reopen the ticket or create a new one in case this issue resurfaces due to a different scenario we're not aware of at this point.

Note: See TracTickets for help on using tickets.