Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#7216 closed defect (fixed)

Options page can be opened multiple times

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: Ross, sebastian, geo Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/30

Description (last modified by kzar)

Environment

Edge 44.17763.1.0, Adblock Plus 0.9.11

How to reproduce

  1. Click the Adblock Plus logo.
  2. Click the Cog symbol to open the options page.
  3. Repeat

Observed behaviour

The options page opens each time the cog button is clicked, even if it was already open.

Expected behaviour

If the options page is already open, clicking the cog should instead switch to that tab.

Notes

  • Thanks to Ross for spotting this one.
  • It seems that Microsoft have added the browser.runtime.openOptionsPage somewhere in between version 42 and 44 of Edge, but it doesn't function properly. It opens the options page each time it's called, even if the options page is already open.
  • See this Microsoft Edge bug: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/20196382/
  • This in turn causes more problems, see #7215.

Change History (6)

comment:1 Changed 5 months ago by kzar

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 months ago by kzar

  • Description modified (diff)

comment:3 Changed 5 months ago by abpbot

A commit referencing this issue has landed:
Issue 7216 - Avoid using broken openOptionsPage API on Edge

comment:4 Changed 5 months ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 5 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed.

ABP 0.9.11.2223 (Devbuild)
Edge 44.17763.1.0 / EdgeHTML 18.17763

comment:6 Changed 5 months ago by sebastian

  • Milestone changed from Adblock-Plus-for-Chrome-Opera-Firefox-next to Adblock-Plus-3.4.3-for-Chrome-Opera-Firefox
Note: See TracTickets for help on using tickets.