Opened on 01/17/2019 at 03:39:29 PM

Closed on 01/23/2019 at 10:46:12 AM

Last modified on 01/24/2019 at 08:50:39 PM

#7222 closed defect (fixed)

Copyright notice missing from first run page on Edge

Reported by: kzar Assignee: kzar
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: sebastian, geo, greiner, Ross, oleksandr, agiammarchi Blocked By:
Blocking: #7233 Platform: Edge
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by kzar)


Microsoft Edge 42.17134.1.0, Adblock Plus 0.9.12

How to reproduce

  1. Install Adblock Plus
  2. Scroll to bottom of the first run page which opens.

Observed behaviour

The copyright notice text is missing from the grey footer.

Expected behaviour

That text should be populated.


  • This does not seem to be a recent regression, but without knowing the revision 0.9.11 was based upon I can't check if this is a regression since the previous release.
  • It seems that the text is not being populated for some reason, despite it working on Chrome and despite the other text on the page being populated OK.
  • See this screenshot.

There are two issues, both in js/first-run.js:

  1. The callback for api.doclinks.get("eyeo") never happens.
  2. browser.i18n.getMessage expects the arguments to be strings, but we were passing the year as a number.

This bodge of a patch got the copyright notice to display for me (Edge 42), but obviously now we need to figure out how to get api.doclinks.get("eyeo") to work properly

  • js/first-run.js

    diff --git a/js/first-run.js b/js/first-run.js
    index 513a63f..7ca9ce4 100644
    a b function initLinks() 
    5454  { 
    5555    ext.i18n.setElementLinks("fair-description", url); 
    5656  }); 
    57   api.doclinks.get("eyeo").then((url) => 
     57  Promise.resolve("").then((url) => 
    5858  { 
    59     const year = new Date().getFullYear(); 
     59    const year = new Date().getFullYear().toString(); 
    6060    const notice = document.getElementById("copyright-notice"); 
    6161    ext.i18n.setElementText(notice, "firstRun_footer_copyright", year); 
    6262    ext.i18n.setElementLinks("copyright-notice", url); 

For Geo (Edge 44), the callback is already happening, so only the .toString() part of the above patch is required.

See also ui#299.

Attachments (0)

Change History (13)

comment:1 Changed on 01/17/2019 at 04:43:12 PM by kzar

  • Description modified (diff)

comment:2 Changed on 01/17/2019 at 04:49:29 PM by kzar

  • Component changed from Platform to User-Interface
  • Priority changed from P2 to Unknown
  • Ready unset

Anyway, it seems like this is a UI issue so I've un-triaged it. Could you triage please Thomas?

comment:3 Changed on 01/17/2019 at 05:07:12 PM by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set

comment:4 Changed on 01/17/2019 at 07:21:38 PM by kzar

  • Cc agiammarchi added

comment:5 Changed on 01/18/2019 at 10:19:57 AM by kzar

  • Description modified (diff)

comment:6 Changed on 01/18/2019 at 10:37:45 AM by kzar

  • Owner set to kzar

Investigating how to get the api.doclinks.get("eyeo") part to work on Edge 42 now.

comment:7 Changed on 01/18/2019 at 11:05:14 AM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed on 01/23/2019 at 10:46:12 AM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed on 01/23/2019 at 10:52:38 AM by greiner

  • Blocking 7233 added

comment:10 Changed on 01/24/2019 at 02:26:46 AM by abpbot

comment:11 Changed on 01/24/2019 at 10:04:19 AM by abpbot

A commit referencing this issue has landed:
Issue 7222 - Fix the first run page copyright notice on Edge

comment:12 Changed on 01/24/2019 at 04:28:27 PM by abpbot

comment:13 Changed on 01/24/2019 at 08:50:39 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Copyright notice is back.
Edge 44.17763.1.0 / EdgeHTML 18.17763 / Windows 10

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.