Opened 10 months ago

Last modified 9 months ago

#7223 closed defect

First run page with data corruption message shows each time Edge starts — at Version 20

Reported by: jparedes Assignee: geo
Priority: P1 Milestone:
Module: Platform Keywords:
Cc: sebastian, geo, kzar, Ross, ukacar, greiner Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/32

Description (last modified by kzar)

Environment

Microsoft Edge versions 42.17134.1.0 & 44.17763.1.0
Adblock Plus version 9.12

How to reproduce

  1. Go back in time, install 9.11.
  2. Get upgraded to 9.12
  3. Disable AA
  4. Restart Edge

Observed behaviour

The first run page is displayed, along with the warning about data corruption.
Subscriptions, AA and other preferences are all lost.

Expected behaviour

The first run page isn't displayed and the subscriptions + settings persist.

Notes

  • Uninstalling and reinstalling Adblock Plus does not fix the issue.
  • Unchecking "clear all cookies and website data" does not fix the issue.

Hints for testers

This change is to the code which handles storage of settings, subscriptions etc for Edge users. Please test anything storage related, for example that AA settings remain, as thoroughly as possible on Edge. You don't need to test at all on other platforms, since this code is not used elsewhere.

Change History (22)

comment:1 Changed 10 months ago by jparedes

  • Description modified (diff)

comment:2 Changed 10 months ago by Ross

The first run page will appear every time if they leave it open in a tab after install and don't close it.

But I guess this is the first run page re-opening on browser start after being closed in a previous browser sesssion.

Does the first run page have the message about reset filters on it?

Clearing "Cached data and files" might help (although not sure).

comment:3 Changed 10 months ago by ukacar

I am also not able to reproduce it, and I've noticed that a simple reinstall of the extension in Edge does not equal the first install - all of the settings are remembered (like whitelisted websites, custom filters, etc.).
I've managed to get a 'fresh install' by uninstalling, clearing cookies and website data, and reinstalling the extension, maybe this can be suggested as a workaround.

Last edited 10 months ago by ukacar (previous) (diff)

comment:4 Changed 10 months ago by kzar

  • Cc sebastian geo kzar Ross ukacar added
  • Description modified (diff)

The issue description talks about the first run page opening every time that Edge starts, but the title talks about the user's filters being lost. Is the title wrong, or is that another symptom?

comment:5 Changed 10 months ago by geo

I'm only able to reproduce it if I have the clear cookies and website data enabled on each browser close and if I close the browser/ turn the extension on/off without waiting at least one minute after starting the browser/turning the extension on.

This is because the backup that is not affected by the clear cookies and website data is created only after one minute. We could create a backup as soon as the extension starts, but that might impact start up times.

comment:6 Changed 10 months ago by kzar

  • Description modified (diff)
  • Summary changed from Microsoft Edge, first run page - all filters removed to First run page with data corruption shows each time Edge starts

comment:7 Changed 10 months ago by kzar

  • Summary changed from First run page with data corruption shows each time Edge starts to First run page with data corruption message shows each time Edge starts

Changed 10 months ago by jparedes

Dev Console Entry of affected user1

Changed 10 months ago by jparedes

Dev Console Entry of affected user2

comment:8 follow-ups: Changed 10 months ago by kzar

We discussed this in IRC, but for completeness here are some questions for affected users:

  • Do you have "..." -> "Settings" -> "Clear browsing data" -> "Always clear this when I close the browser" toggle enabled? (See Geo's comment.)
  • How often are you restarting Edge?
  • What configuration is getting lost? Just the AA setting, or other preferences, custom subscriptions or custom filters?

Also, I'm curious roughly how many people have reported this problem so far?

comment:9 in reply to: ↑ 8 ; follow-up: Changed 10 months ago by jparedes

Replying to kzar:

We discussed this in IRC, but for completeness here are some questions for affected users:

  • Do you have "..." -> "Settings" -> "Clear browsing data" -> "Always clear this when I close the browser" toggle enabled? (See Geo's comment.)
  • How often are you restarting Edge?
  • What configuration is getting lost? Just the AA setting, or other preferences, custom subscriptions or custom filters?

Also, I'm curious roughly how many people have reported this problem so far?

We're still awaiting responses for the "Always clear this when I close the browser" toggle.
Edge restart answers have ranged from 10-50 times a day.
We've received notice that AA settings, other preferences and custom "My filter list" entries are being removed.

Roughly 80 Individual Users have reported this issue via Email in the past 30 hours.

comment:10 Changed 10 months ago by kzar

  • Description modified (diff)

I see, so we're not sure if AA or any other settings get reverted, just that the message on the first run page mentions to check AA settings.

comment:11 in reply to: ↑ 9 Changed 10 months ago by geo

Replying to jparedes:

We're still awaiting responses for the "Always clear this when I close the browser" toggle.
Edge restart answers have ranged from 10-50 times a day.

Do we know if they do anything immediately after seeing the first run page (browser/extension restart) or do they wait for a bit?

Last edited 10 months ago by geo (previous) (diff)

comment:12 in reply to: ↑ 8 Changed 10 months ago by sebastian

Replying to geo:

I'm only able to reproduce it if I have the clear cookies and website data enabled on each browser close and if I close the browser/ turn the extension on/off without waiting at least one minute after starting the browser/turning the extension on.

This is because the backup that is not affected by the clear cookies and website data is created only after one minute. We could create a backup as soon as the extension starts, but that might impact start up times.

That is expected, and an improvement to the previous release, where that would happen when browsing data are cleared, regardless how long you kept Microsoft Edge open previously.

Replying to kzar:

Also, I'm curious roughly how many people have reported this problem so far?

FWIW, there were 3 reviews on the Windows Store after we released 0.9.12, related to this issue. At least 2 of them indicate they updated from a previous version, one is saying that it doesn't block any ads either which might indicate that the initialization failed, rather than the data getting lost later on.

Last edited 10 months ago by sebastian (previous) (diff)

comment:13 Changed 10 months ago by geo

  • Owner set to geo
  • Review URL(s) modified (diff)

comment:14 Changed 10 months ago by sebastian

We identified two inconsistencies in the code that are likely related to this issue. We have a potential fix that we plan to release after the 3.4.3 release for Chrome/Firefox. However, since we cannot reproduce the issue, we don't know for sure whether this change will effectively resolve it.

comment:15 Changed 10 months ago by imowom

Hello..

Mine is doing this. I don't have clear cookies checked.

Tried a re-install of ABP.. No luck.

Microsoft Edge 44.17763.1.0

OS Build 17763.253

ABP Version number 0.9.12

Mo

Last edited 10 months ago by imowom (previous) (diff)

comment:16 Changed 10 months ago by jparedes

Users confirm that AA preferences are being lost, same to Custom Filters and other preferences.
We have now received over 400 reports on this issue since update.

Work-around with uninstalling and re-installing is generally not successful.
We do have 3 users who reported that it's solved their issue.

comment:17 follow-up: Changed 10 months ago by philll

Could we create an experimental build to have some affected users try out the suggested fix?

comment:18 Changed 10 months ago by kzar

  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set

comment:19 in reply to: ↑ 17 Changed 10 months ago by kzar

Replying to philll:

Could we create an experimental build to have some affected users try out the suggested fix?

Sounds like a good idea to me, I started a discussion about how we could possibly do that on the codereview. We'll keep you posted.

comment:20 Changed 10 months ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.