Opened 2 months ago

Closed 2 months ago

Last modified 11 days ago

#7232 closed change (fixed)

Move function for checking if a request is third-party into adblockpluscore

Reported by: mjethani Assignee: mjethani
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29987585/

Description (last modified by mjethani)

Background

In #7121 we moved the public suffix list into adblockpluscore. Now the isThirdParty function in lib/url.js in adblockpluschrome, which is one of the top hot spots, can also be moved into adblockpluscore.

What to change

Copy the isThirdParty function and related code from lib/url.js in adblockpluschrome to lib/domain.js in adblockpluscore.

Copy related tests from qunit/tests/url.js in adblockpluschrome into test/domain.jsin adblockpluscore.

Hints for testers

This new version of this function is not called from the extension yet, but please look for hints in the dependency update ticket.

Change History (7)

comment:1 Changed 2 months ago by mjethani

  • Owner set to mjethani

comment:2 Changed 2 months ago by mjethani

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 months ago by mjethani

  • Description modified (diff)

comment:4 Changed 2 months ago by abpbot

A commit referencing this issue has landed:
Issue 7232 - Move third-party request check into adblockpluscore

comment:5 Changed 2 months ago by mjethani

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 6 weeks ago by abpbot

A commit referencing this issue has landed:
Issue 7232 - Move third-party request check into adblockpluscore

comment:7 Changed 11 days ago by rscott

  • Verified working set
Note: See TracTickets for help on using tickets.