Opened 15 months ago

Last modified 12 months ago

#7236 closed change

Handle sub properties in abort-on-property-* snippets. — at Version 5

Reported by: hfiguiere Assignee: hfiguiere
Priority: P2 Milestone:
Module: Core Keywords: circumvention
Cc: mjethani, arthur, amr Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29995559/

Description

Background

Currently we only support a simple property (like property1) in abort-on-property-read and abort-on-property-write. We need to support any like object1.property1

What to change

  • Change wrapPropertyAccess() in lib/contentn/snippets.js to deal with that case.

Hint to testers

TBD

Change History (5)

comment:1 Changed 15 months ago by hfiguiere

  • Cc mjethani added

comment:2 Changed 15 months ago by arthur

  • Cc arthur added

comment:3 Changed 15 months ago by hfiguiere

  • Keywords circumvention added

comment:4 Changed 14 months ago by hfiguiere

  • Owner set to hfiguiere

comment:5 Changed 14 months ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.