Opened 11 months ago

Closed 10 months ago

Last modified 9 months ago

#7238 closed change (fixed)

Fix multi-locale builds

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.5.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29989567/

Description (last modified by diegocarloslima)

Background

Currently, we use mozharness to generate our multi-locale builds. It seems that Mozilla doesn't use it to generate Android multi-locale builds for a long time. With the last merge, the multi-locale build now throws an error and fails when trying to build the project.

What to change

We should find an alternative way to generate multi-locale builds. As reference, I could find some articles/issues related to this issue:
Simple Firefox for Android build
Building and testing multi-locale Firefox for Android
Instructions for multi-locale builds
Bug 1362496 - Add chrome-% for Firefox

For this ticket, we should also consider skipping the toolkit/mozapps/installer/find-dupes.py script. We already had to add in the past some exceptions to mobile/android/installer/allowed-dupes.mn and it looks like we would need to add a considerable amount of new rules for this issue. Also, it seems that the find-dupes script can sometimes lead to Resource temporarily unavailable error, since it seems to try to open lots of files at the same time.

Change History (5)

comment:1 Changed 11 months ago by diegocarloslima

  • Description modified (diff)

comment:2 Changed 11 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 7238 - Fix multi-locale builds

comment:4 Changed 10 months ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 9 months ago by aboegler

QA LGTM, changing language in Android OS settings and browser settings working as expected.

Note: See TracTickets for help on using tickets.