Opened 5 years ago

Last modified 4 years ago

#724 new defect

Radio boxes in Android settings menu are not veritcally aligned

Reported by: philll Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Android Keywords: android_devbuild_1.3 goodfirstbug
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Taken from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ABP-13

Environment

LG + LG P-895 + Android Version - 4.0.4
ABP 1.2.1.327, Build 327

How to reproduce

  1. Open the settings menu

Observed behaviour

The radio buttons for the fields "Acceptable Ads" and "Hide Button" are not vertically aligned properly.

Expected behaviour

The radio buttons for the fields "Acceptable Ads" and "Hide Button" should be aligned properly.

Attachments (6)

HelpfulCheckBoxPreference.java (2.1 KB) - added by agnieszka.domanska 4 years ago.
preferences.xml (1.3 KB) - added by agnieszka.domanska 4 years ago.
layouts to helpfulCheckboxPreference i 'Hide Icon' checkboxPreference added
strings.xml (7.1 KB) - added by agnieszka.domanska 4 years ago.
typo fixed
helpfulcheckbox_layout.2.xml (1.2 KB) - added by agnieszka.domanska 4 years ago.
helpfulcheckbox_layout.xml (1.2 KB) - added by agnieszka.domanska 4 years ago.
new custom layout for helpfulCheckboxPreference
hideicon_layout.xml (1.5 KB) - added by agnieszka.domanska 4 years ago.
new custom layout for 'Hide Icon' checkboxPreference - unnecessary to align it with helpfulCheckboxPreference

Download all attachments as: .zip

Change History (13)

comment:1 Changed 5 years ago by fhd

  • Keywords goodfirstbug added
  • Platform set to Android

comment:2 Changed 4 years ago by Mailkov

Hi , I would like to work on this bug.

comment:3 Changed 4 years ago by Mailkov

Hi , I would like to work on this defect

comment:4 Changed 4 years ago by agnieszka.domanska

Hi, I would like to work on this. Good as first bug.

comment:5 Changed 4 years ago by agnieszka.domanska

Hi. I think I solved the problem. I attached changed or added files. These are:

res/layout/helpfulcheckbox_layout.xml
res/layout/hideicon_layout.xml
res/xml/preferences.xml
src/org/adblockplus/android/HelpfulCheckBoxPreference.java
res/values-pl/strings.xml (here I just fixed a little typo)

helpfulcheckbox_layout.2.xml file is not needed. I don't know how to remove it.

Last edited 4 years ago by agnieszka.domanska (previous) (diff)

Changed 4 years ago by agnieszka.domanska

Changed 4 years ago by agnieszka.domanska

layouts to helpfulCheckboxPreference i 'Hide Icon' checkboxPreference added

Changed 4 years ago by agnieszka.domanska

typo fixed

Changed 4 years ago by agnieszka.domanska

Changed 4 years ago by agnieszka.domanska

new custom layout for helpfulCheckboxPreference

Changed 4 years ago by agnieszka.domanska

new custom layout for 'Hide Icon' checkboxPreference - unnecessary to align it with helpfulCheckboxPreference

comment:6 Changed 4 years ago by agnieszka.domanska

Last edited 4 years ago by agnieszka.domanska (previous) (diff)

comment:7 Changed 4 years ago by agnieszka.domanska

Pull request with a fix sent on github.

Note: See TracTickets for help on using tickets.