Opened 11 months ago

Closed 4 months ago

#7240 closed change (rejected)

Provide script to rebuild resources.json

Reported by: hfiguiere Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Automation Keywords:
Cc: sebastian, mjethani Blocked By: #7067
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29933567/
https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/101

Description

Background

Issue #7067 introduced resources.json.

Provide the necessary files to rebuild the resources.json, including adding more to it.

What to change

  • Add the make_resources.js script file
  • Add an entry in the package.json
  • Add the necessary sources (binaries and index)

Change History (5)

comment:1 Changed 11 months ago by hfiguiere

  • Owner set to hfiguiere

comment:2 Changed 11 months ago by hfiguiere

  • Status changed from new to reviewing

comment:3 Changed 5 months ago by hfiguiere

  • Review URL(s) modified (diff)

comment:4 Changed 4 months ago by mjethani

Any reason why this is marked confidential?

comment:5 Changed 4 months ago by sebastian

  • Cc sebastian mjethani added
  • Component changed from Core to Automation
  • Resolution set to rejected
  • Sensitive unset
  • Status changed from reviewing to closed

Rejecting this issue for reasons outlined in the merge request.

Note: See TracTickets for help on using tickets.