Opened 11 months ago

Closed 9 months ago

Last modified 9 months ago

#7243 closed change (fixed)

Update adblockpluscore dependency to hg:91cd83c4c272

Reported by: mjethani Assignee: mjethani
Priority: Unknown Milestone: Adblock-Plus-3.5-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: hfiguiere, amr, arthur Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29991594/

Description (last modified by mjethani)

Background

We have made a few more significant changes to the next branch of adblockpluscore since the last dependency update (#7054).

Here are the relevant changes:

What to change

Update the adblockpluscore dependency to hg:91cd83c4c272 git:0798938.

In lib/hitLogger.js, use the new hasListeners method of EventEmitter (#7202).

Use the isThirdParty function from adblockpluscore/lib/domain.js (#7232) in lib/*. Delete lib/tldjs.js and lib/publicSuffixList.js. Delete the third-party checks in qunit/tests/url.js.

In lib/csp.js, call the new search method of defaultMatcher (#7179) to get all the matching CSP filters and inject the corresponding headers into the response.

Notes for filter list authors

The order of filters is no longer randomized (#7178). If an existing filter is superseding your user-defined filter, restarting the extension is not going to change this. We are looking into ways to prioritize user-defined filters (#7248).

This has usually been an issue for CSP filters. After the changes here, all CSP filters that match a document are applied. All matching blocking CSP filters will also be logged in the DevTools panel.

The $rewrite filter option can now redirect to internal resources like blank HTML/CSS/JavaScript, 1x1 transparent (tracking) GIF/PNG, and so on (#7067), though this is currently experimental.

Hints for testers

See #7178, #7208, #7209, #7235, #7244, #7245, and #7067 for testing hints related to those changes in adblockpluscore.

For the additional changes here:

  1. Make sure the DevTools panel is working in general and that filter hits are getting logged as expected.
  2. For CSP filters, make sure all matching CSP filters are applied. For example, if there are two filters /foo/*$csp=script-src 'none' and /foo/*$csp=img-src 'none', then both scripts and images should be blocked entirely on a document whose URL matches the pattern /foo/*.
  3. Multiple CSP filter hits should get logged in the DevTools panel. If there are two filters /foo/*$csp=img-src 'none' and /bar/*$csp=img-src 'none', then on the document https://example.com/foo/bar/index.html both filters should get hit and both should get logged in the DevTools panel.
  4. In the case of whitelist CSP filters, only the first matching filter should get logged in the DevTools panel. For example, with @@/foo/*$csp and @@/bar/*$csp, only one of them should get hit and logged in the DevTools panel on the document https://example.com/foo/bar/index.html.
  5. Check that the $third-party filter option is working. If there's a filter like /foo/*$third-party then it should block a request to https://example.com/foo/bar/ only if the request is coming from a document not loaded from example.com. If the flag is flipped instead so that the filter looks like /foo/*$~third-party, then it should not block the request unless it is coming from example.com.

Change History (13)

comment:1 Changed 11 months ago by mjethani

  • Description modified (diff)

comment:2 Changed 11 months ago by mjethani

  • Description modified (diff)

comment:3 Changed 10 months ago by hfiguiere

  • Cc hfiguiere added

comment:4 Changed 10 months ago by mjethani

  • Description modified (diff)
  • Summary changed from Update adblockpluscore dependency to hg:e26e122e0702 to Update adblockpluscore dependency to hg:91cd83c4c272

comment:5 Changed 10 months ago by sebastian

  • Description modified (diff)

comment:6 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 7243 - Update adblockpluscore dependency to hg:e26e122e0702

comment:7 Changed 10 months ago by mjethani

  • Description modified (diff)

comment:8 Changed 10 months ago by mjethani

  • Cc amr arthur added

comment:9 Changed 10 months ago by mjethani

  • Description modified (diff)

comment:10 Changed 10 months ago by mjethani

  • Description modified (diff)

comment:11 Changed 9 months ago by mjethani

  • Milestone set to Adblock-Plus-3.5-for-Chrome-Opera-Firefox
  • Resolution set to fixed
  • Status changed from new to closed

comment:12 Changed 9 months ago by mjethani

  • Owner set to mjethani

comment:13 Changed 9 months ago by rscott

  • Verified working set
Note: See TracTickets for help on using tickets.