Opened 5 months ago

Last modified 5 months ago

#7246 new defect

Whitelisting of domain downgraded after enabling and then disabling extension on domain

Reported by: kgalczynski Assignee:
Priority: Unknown Milestone:
Module: User-Interface Keywords: whitelisting, broken filter
Cc: greiner, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Environment

Windows 10 Pro 64bit
Chrome 71.0.3578.98 (Official Build) (64-bit) [tested also on FF]
Adblock PLus 3.4.3
Filter lists:

  • Easylist
  • ABP filters
  • Allow nonintrusive advertising

Affected filter in AA:
@@||btserve.com^$document,subdocument,image

How to reproduce

Link 1:
https://champion.gg/
Link 2:
https://www.btserve.com/serve?t=bidt&v=1&pubId=185&siteId=691&placementId=3591&placementUid=5b15aee8f0-185&idx=1&pgid=df11d01b-714f-ec4e-f112-38165e3efe27&o=https%3A%2F%2Fchampion.gg%2F&

  1. Go to link 1 - you should see ads
  2. in new tab go to link 2 - ABP icon should be grey. Switch on blocking on btserve.com
  3. refresh link 1 - ads are gone
  4. go to tab with link 2 - switch off blocking on btserve.com
  5. refresh link 1 - ads are still gone.

To fix reinstall ABP

Observed behaviour

Filter is still not working, even after updating ABP, updating AA or switching off/on browser

Expected behaviour

It should switch on filter
@@||btserve.com^$document,subdocument,image
on whitelist instead of adding filter
@@||btserve.com^$document
to whitelisted websites

Change History (2)

comment:1 Changed 5 months ago by greiner

  • Cc greiner added

comment:2 Changed 5 months ago by greiner

  • Cc sebastian added
  • Component changed from Unknown to User-Interface
  • Description modified (diff)
  • Summary changed from Blacklisting list on whitelist is breaking filter to Whitelisting of domain downgraded after enabling and then disabling extension on domain

This is a known issue (see ui#210). The issue is that in order to enable Adblock Plus on a domain, all applicable whitelist filters need to be disabled (incl. ones from downloadable filter lists like EasyList). When enabling ad blocking for the domain again, however, all the extension does is add the filter @@||example.com^$document which.

While this behavior has been around for years, we never had a way to enable disabled filters from downloadable filter lists in web extensions so allowing users to reenable such disabled filters would be one way to handle it. Ideally, we'd be reenabling all relevant filters instead of merely adding a new one to reset the extension to its prior state but that may require changes to Platform and/or Core.

Note: See TracTickets for help on using tickets.