Opened 9 months ago

Closed 7 months ago

Last modified 3 months ago

#7247 closed change (fixed)

Improve filter table search visualization

Reported by: agiammarchi Assignee: agiammarchi
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #6936 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/210

Description (last modified by agiammarchi)

As mentioned in https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/294, it is actually not fully clear by either specs or implementation how matching searches should be somehow highlighted in the list of custom filters.

As discussed in this comment https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/294#note_136451655 we would like to give the users a powerful way to visualize their searches:

  • automatically select any matching custom filter in the list
  • give the ability to delete or copy all matches
  • scroll into the closest match from the top or
  • scroll into the exact match, if any

The search will perform only if there are at least 3 chars in the text field, otherwise nothing would happen.

Change History (7)

comment:1 Changed 9 months ago by agiammarchi

  • Review URL(s) modified (diff)

comment:2 Changed 9 months ago by agiammarchi

  • Description modified (diff)

comment:3 Changed 7 months ago by greiner

  • Blocking 6936 added

comment:4 Changed 7 months ago by greiner

  • Owner set to agiammarchi
  • Priority changed from Unknown to P3

comment:5 Changed 7 months ago by greiner

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 5 months ago by abpbot

A commit referencing this issue has landed:
Issue 7247 - Improve filter table search visualization

comment:7 Changed 3 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.