Changes between Version 6 and Version 7 of Ticket #7253


Ignore:
Timestamp:
02/03/2019 11:45:24 AM (7 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7253 – Description

    v6 v7  
    1616 
    1717In `ext/background.js`, if the `imageData` parameter is set, pass the value to `chrome.browserAction.setIcon`; otherwise pass `path` as usual. 
     18 
     19=== Hints for testers === 
     20Try this: 
     21 
     22 1.  Open two windows, load a site like nytimes.com in one and a site like msn.com in the other (but really any site where some ads are being blocked will do) 
     23 2.  In one of the windows, disable ad blocking for the domain 
     24 3.  Make sure the icon is gray after disabling ad blocking; also make sure it looks alright (quality is OK compared with previous version of Adblock Plus) 
     25 4.  Switch between the two windows and see that the icon changes between red (enabled) and gray (disabled); also make sure that the quality of the red icon is alright 
     26 
     27Try this on the oldest supported version of Chrome (49+) as well as the latest version of Chrome. 
     28 
     29Also see #7256.