Opened 7 months ago

Closed 7 months ago

Last modified 6 months ago

#7256 closed change (fixed)

Stop using 19x19 and 38x38 icons

Reported by: mjethani Assignee: mjethani
Priority: P2 Milestone: Adblock-Plus-3.5-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29997602/

Description (last modified by mjethani)

Background

Chrome used to require extension icons to be of sizes 19x19 and 38x38. After Chromium bug #564926, it started accepting icons of other sizes. By now the 19x19 and 38x38 versions are no longer required (though on older versions of Chrome the icons may still be scaled to these sizes). No other platform that we support for the WebExt version of Adblock Plus (Firefox, Edge) requires the 19x19 and 38x38 sizes. We can therefore safely stop using icons of these sizes.

What to change

Modify ext/background.js, lib/icon.js, and metadata.chrome to remove the entries for the 19x19 and 38x38 versions of the icons. Delete the relevant icons/abp-19* and icons/abp-38* files.

Hints for testers

Make sure the badge icons are rendered correctly on older versions of Chrome (esp. Chrome 49 and Chrome 50). Try both the whitelisted and the non-whitelisted versions (i.e. turn off ad blocking on the page and see that the gray icon looks alright). For the non-whitelisted (red) version, make sure it looks alright with the badge text (number of ads blocked).

Change History (9)

comment:1 Changed 7 months ago by abpbot

A commit referencing this issue has landed:
Issue 7256 - Stop using 19x19 and 38x38 icons

comment:2 Changed 7 months ago by mjethani

  • Review URL(s) modified (diff)

comment:3 Changed 7 months ago by mjethani

  • Description modified (diff)
  • Type changed from defect to change

comment:4 Changed 7 months ago by mjethani

  • Description modified (diff)
  • Owner set to mjethani

comment:5 Changed 7 months ago by mjethani

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 7 months ago by mjethani

  • Cc sebastian kzar added

comment:7 Changed 7 months ago by mjethani

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next

comment:8 Changed 7 months ago by sebastian

  • Priority changed from Unknown to P2
  • Ready set

comment:9 Changed 6 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.