Changes between Version 2 and Version 3 of Ticket #7256


Ignore:
Timestamp:
02/03/2019 11:16:52 AM (8 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7256

    • Property Type changed from defect to change
  • Ticket #7256 – Description

    v2 v3  
    1 === Environment === 
    2 Replace this text with the Version of your operating system, your exact browser version, the used Adblock Plus version and the enabled Filter lists. 
     1=== Background === 
     2After ​https://crbug.com/564926 Chrome started accepting icons of sizes other than 19x19 and 38x38. Now 19x19 and 38x38 are no longer required (though on older versions of Chrome the icons may still be scaled to these sizes). No other platform we support for the WebExt version of Adblock Plus (Firefox, Edge) requires the 19x19 and 38x38 sizes. We can therefore safely remove the icons of these sizes. 
    33 
    4 === How to reproduce === 
    5  1. Step one of your reproduction process (e.g: Go to http://example.com/  
    6  2. Step two of your reproduction process (e.g: Click the big red button labelled "click me" at the left) 
    7  3. Step three of your reproduction process 
    8  4. Step four of your reproduction process 
    9 ... 
    10  
    11 === Observed behaviour === 
    12 Replace this text with your detailed observations. 
    13  
    14 === Expected behaviour === 
    15 Replace this text with your detailed expectations. 
     4=== What to change === 
     5Modify `ext/background.js`, `lib/icon.js`, and `metadata.chrome` to remove entries for the 19x19 and 38x38 versions of the icons. Delete the relevant `icons/abp-19*` and `icons/abp-38*` files.