Changes between Version 3 and Version 4 of Ticket #7256


Ignore:
Timestamp:
02/03/2019 11:32:33 AM (8 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7256

    • Property Owner set to mjethani
  • Ticket #7256 – Description

    v3 v4  
    11=== Background === 
    2 After ​https://crbug.com/564926 Chrome started accepting icons of sizes other than 19x19 and 38x38. Now 19x19 and 38x38 are no longer required (though on older versions of Chrome the icons may still be scaled to these sizes). No other platform we support for the WebExt version of Adblock Plus (Firefox, Edge) requires the 19x19 and 38x38 sizes. We can therefore safely remove the icons of these sizes. 
     2Chrome used to require extension icons to be of sizes 19x19 and 38x38. After [https://crbug.com/564926 Chromium bug #564926], it started accepting icons of other sizes. By now the 19x19 and 38x38 versions are no longer required (though on older versions of Chrome the icons may still be scaled to these sizes). No other platform that we support for the WebExt version of Adblock Plus (Firefox, Edge) requires the 19x19 and 38x38 sizes. We can therefore safely stop using icons of these sizes. 
    33 
    44=== What to change === 
    5 Modify `ext/background.js`, `lib/icon.js`, and `metadata.chrome` to remove entries for the 19x19 and 38x38 versions of the icons. Delete the relevant `icons/abp-19*` and `icons/abp-38*` files. 
     5Modify `ext/background.js`, `lib/icon.js`, and `metadata.chrome` to remove the entries for the 19x19 and 38x38 versions of the icons. Delete the relevant `icons/abp-19*` and `icons/abp-38*` files. 
     6 
     7=== Hints for testers === 
     8Make sure the badge icons are rendered correctly on older versions of Chrome (esp. Chrome 49 and Chrome 50). Try both the whitelisted and the non-whitelisted versions (i.e. turn off ad blocking on the page and see that the gray icon looks alright). For the non-whitelisted (red) version, make sure it looks alright with the badge text (number of ads blocked).