Opened 18 months ago

Last modified 18 months ago

#7256 closed change

Stop using 19x19 and 38x38 icons — at Version 3

Reported by: mjethani Assignee:
Priority: P2 Milestone: Adblock-Plus-3.5-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29997602/

Description (last modified by mjethani)

Background

After ​https://crbug.com/564926 Chrome started accepting icons of sizes other than 19x19 and 38x38. Now 19x19 and 38x38 are no longer required (though on older versions of Chrome the icons may still be scaled to these sizes). No other platform we support for the WebExt version of Adblock Plus (Firefox, Edge) requires the 19x19 and 38x38 sizes. We can therefore safely remove the icons of these sizes.

What to change

Modify ext/background.js, lib/icon.js, and metadata.chrome to remove entries for the 19x19 and 38x38 versions of the icons. Delete the relevant icons/abp-19* and icons/abp-38* files.

Change History (3)

comment:1 Changed 18 months ago by abpbot

A commit referencing this issue has landed:
Issue 7256 - Stop using 19x19 and 38x38 icons

comment:2 Changed 18 months ago by mjethani

  • Review URL(s) modified (diff)

comment:3 Changed 18 months ago by mjethani

  • Description modified (diff)
  • Type changed from defect to change
Note: See TracTickets for help on using tickets.