Opened on 02/05/2019 at 02:37:51 PM

Closed on 02/06/2019 at 03:36:20 AM

Last modified on 02/07/2019 at 03:24:12 AM

#7262 closed defect (fixed)

npm test fail with more that one test for browser in adblockpluscore

Reported by: hfiguiere Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Automation Keywords:
Cc: tlucas, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by hfiguiere)


If there is more than one test file in test/browser, npm test fails.
This is only with WebDriver, either Chrome or Firefox. The Chrome remote interface is exempt.

How to reproduce

  1. Add a new test file in test/browser
  2. Run npm test with the default

Observed behaviour

Chrome test with the remote interface will pass.

Test will timeout:

Browser unit test failed: ScriptTimeoutError: Timed out
npm ERR! Test failed.  See above for more details.

Expected behaviour

All test pass.


If run with Chrome webdriver, the Chrome test timeout as well.

Attachments (0)

Change History (11)

comment:1 Changed on 02/05/2019 at 02:38:19 PM by hfiguiere

  • Cc tristan added; removed

comment:2 Changed on 02/05/2019 at 02:41:36 PM by hfiguiere

  • Cc tlucas added; tristan removed

comment:3 Changed on 02/05/2019 at 02:42:31 PM by hfiguiere

  • Description modified (diff)

comment:4 Changed on 02/05/2019 at 10:14:03 PM by sebastian

My guess would be that this is because you don't properly shutdown the first browser instance (by calling quit()) after calling runScript() in chromium_process.js. Even better you would reuse the same web driver instance for running multiple test scripts.

Last edited on 02/05/2019 at 10:14:56 PM by sebastian

comment:5 Changed on 02/05/2019 at 10:48:29 PM by hfiguiere

  • Owner set to hfiguiere
  • Review URL(s) modified (diff)

comment:6 Changed on 02/05/2019 at 10:48:36 PM by hfiguiere

  • Status changed from new to reviewing

comment:7 Changed on 02/05/2019 at 10:49:01 PM by hfiguiere

It was simpler than that.

comment:8 Changed on 02/06/2019 at 12:05:27 AM by jsonesen

Oh hey, I recon this fixes #7263 as well, or at least fixes part of the issue since I still get timeouts even when I don't receive the protocol command error from webdriver

Last edited on 02/06/2019 at 12:06:21 AM by jsonesen

comment:9 Changed on 02/06/2019 at 03:35:06 AM by abpbot

A commit referencing this issue has landed:
Issue 7262 - Allow more than one test

comment:10 Changed on 02/06/2019 at 03:36:20 AM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed on 02/07/2019 at 03:24:12 AM by abpbot

A commit referencing this issue has landed:
Issue 7262 - Allow more than one test

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Note: See TracTickets for help on using tickets.