Changes between Initial Version and Version 2 of Ticket #7265


Ignore:
Timestamp:
02/07/2019 05:43:30 AM (5 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7265

    • Property Owner set to mjethani
    • Property Priority changed from Unknown to P2
    • Property Ready set
  • Ticket #7265 – Description

    initial v2  
    11=== Background === 
    2 Replace this text with your reasoning that lead to wanting the change. 
     2In EasyList, out of ~41,000 request blocking filters, about 26,000 are not location-only (#6994). For these filters we must call `RegExpFilter.prototype.matches`, which checks that the filter applies on the document's domain using `ActiveFilter.prototype.isActiveOnDomain`. Out of these filters, about 3,000 (12%) apply only on specific domains. If we includes Acceptable Ads, the number of such filters is approximately 33,000, and some 6,700 (20%) of these apply on only specific domains. 
     3 
     4If we organize these filters by domain as they are added to the matcher, as we do for element hiding filters, we could avoid the call to `ActiveFilter.prototype.isActiveOnDomain` altogether. 
     5 
     6In my tests this significantly speeds up the performance of filter matching by ~10-15%. 
    37 
    48=== What to change === 
    5 Replace this text with the detailed description of what exactly shall be changed/added and where. 
     9See [https://codereview.adblockplus.org/30000586/ patch].