Changes between Version 3 and Version 4 of Ticket #7265


Ignore:
Timestamp:
02/07/2019 06:00:34 AM (7 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7265 – Description

    v3 v4  
    77The information below is based on the [https://codereview.adblockplus.org/30000586/ patch]. 
    88 
    9 In my tests, this change significantly speeds up the performance of filter matching by around 10-15% (EasyList only). 
     9In my tests, this change significantly speeds up filter matching, by around 10-15% (EasyList only). 
    1010 
    1111The amount of time spent in the `Matcher.prototype.add` function goes up by ~60%, because of the additional processing for organize the filters into domain-specific maps, which affects startup time. 
    1212 
    13 The initial memory footprint goes up from ~53 MB to ~62 MB (EasyList only). This in particular is a big regression. It should be possible to address this with some clever tricks in the construction of the `Matcher.prototype._filterDomainMapsByKeyword` data structure. 
     13The '''initial memory footprint goes up''' from ~53 MB to ~62 MB (EasyList only). This in particular is a '''big regression'''. It should be possible to address this with some clever tricks in the construction of the `Matcher.prototype._filterDomainMapsByKeyword` data structure. 
    1414 
    1515=== What to change ===