Changes between Version 4 and Version 5 of Ticket #7265


Ignore:
Timestamp:
02/07/2019 06:07:50 AM (6 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7265 – Description

    v4 v5  
    1515=== What to change === 
    1616See [https://codereview.adblockplus.org/30000586/ patch]. 
     17 
     18=== Hints for testers === 
     19This change affects all filter matching for request blocking and request whitelisting filters. 
     20 
     21In particular, make sure that domain-specific filters are working correctly. For example, `||foo.example.com/test^$domain=bar.example.com` should block a request to `https://foo.example.com/test` from a document on `bar.example.com` but not from documents on other domains. It should also block the request if it's from a document on `no.bar.example.com` (subdomain of `bar.example.com`). If the filter is modified to `||foo.example.com/test^$domain=bar.example.com|~no.bar.example.com`, however, the request should not be blocked if it's coming from a document on `no.bar.example.com`.