Changes between Version 5 and Version 6 of Ticket #7265


Ignore:
Timestamp:
02/07/2019 06:19:22 AM (4 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7265 – Description

    v5 v6  
    1616See [https://codereview.adblockplus.org/30000586/ patch]. 
    1717 
     18Basically, in `lib/matcher.js`, organize filters by domain, by keyword, similar to the way it is done for element hiding filters in `lib/elemHide.js`. 
     19 
     20A couple of optimizations: 
     21 
     22 1.  Avoid caching the domain map for `RegExpFilter` objects now since the `domains` property needs to be accessed only once. 
     23 2.  There will be too many entries like `Map { "foo" => Map { "" => Map { BlockingFilter => true } } }` (keyword `foo` has one generic filter only). These can be reduced to `Map { "foo" => Map { "" => BlockingFilter } }` by making the `RegExpFilter` object pretend to be a map (duck typing) with itself as the key and `true` as the value. 
     24 
    1825=== Hints for testers === 
    1926This change affects all filter matching for request blocking and request whitelisting filters.