Changes between Version 4 and Version 6 of Ticket #7271


Ignore:
Timestamp:
03/05/2019 03:20:40 PM (9 months ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7271

    • Property Blocked By changed from to 7327
  • Ticket #7271 – Description

    v4 v6  
    1010 
    1111=== What to change === 
    12 Where possible use Promises instead of callbacks when using the `browser.*` or `chrome.*` APIs. If necessary wrap them - see `adblockpluschrome/polyfill.js`. 
     12- Where possible use Promises instead of callbacks when using the `browser.*` or `chrome.*` APIs. 
     13- Rewrite the lib/options.js code around promises. 
     14- Update the adblockplusui dependency to include the related changes for #7327. 
    1315 
    1416=== Notes === 
    1517- See #7272 for the equivalent adblockplusui changes. 
     18 
     19=== Hints for testers === 
     20Unfortunately a whole bunch of code paths were touched with these changes. As far as possible please smoke test all functionality with Edge, old version of Chrome, new version of Chrome, Firefox on mobile, old version of Firefox desktop and new version of Firefox desktop. 
     21 
     22A (not complete) list of functionality that was touched: 
     23 - Logic to open options page, both from popup, notifications and subscription links. 
     24 - "Block element" tool. 
     25 - Our developer tools panel. 
     26 - Collapsing (hiding) of blocked elements. 
     27 - Element hiding. 
     28 - WebRTC blocking. 
     29 - ABP icon animations (e.g. when a critical notification is received). 
     30 - Block counter, including after the preference to show it is disabled then enabled again. 
     31 - Options page opening correctly on mobile vs desktop.