Opened 6 months ago

Closed 5 months ago

Last modified 2 months ago

#7272 closed change (fixed)

Use promises for extension API calls in UI

Reported by: greiner Assignee: hfiguiere
Priority: P2 Milestone:
Module: User-Interface Keywords: manifestv3
Cc: Blocked By:
Blocking: #7334, #7343 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/242

Description (last modified by greiner)

Background

See ui#323

What to change

See ui#323

Hints for testers

This change affects large parts of the functionality in the following UIs:

  • Bubble UI
  • Desktop options page
  • DevTools panel
  • Issue reporter
  • Mobile options page

In particular when it comes to:

  • Accessing extension data (settings, filters, filter lists etc.) and other browser data (e.g. screenshot in issue reporter)
  • Changing extension data and showing errors, if necessary
  • Reacting to changes in extension data
  • Initializing external links

Apart from those, the lang and dir attributes should be correctly set on the <html> element of a UI to reflect the UI locale and text direction.

Change History (11)

comment:1 Changed 6 months ago by greiner

  • Keywords manifestv3 added

comment:2 Changed 6 months ago by greiner

  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 6 months ago by kzar

  • Blocking 7334 added

comment:4 Changed 5 months ago by hfiguiere

  • Owner set to hfiguiere

comment:5 Changed 5 months ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 5 months ago by greiner

  • Description modified (diff)

Added hints for testers.

@hfiguiere Please check and add to/correct it, if necessary.

comment:7 Changed 5 months ago by greiner

  • Blocking 7343 added

comment:8 Changed 5 months ago by greiner

FYI I've also created #7345 and #7346 to take care of any code in the two upcoming major UI dependency updates to ensure that those will also be compatible with the changes in #7271.

comment:9 Changed 5 months ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 5 months ago by abpbot

A commit referencing this issue has landed:
Issue 7272 - Use the extension Promise API

comment:11 Changed 2 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.