Opened on 02/11/2019 at 02:09:44 PM

Closed on 02/11/2019 at 03:56:49 PM

Last modified on 08/26/2019 at 02:27:01 PM

#7273 closed change (fixed)

Resolve translations for error messages in UI

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)


See ui#320

What to change

See ui#320

Notes for dependency update

FilterParsingError.toString() function in adblockpluschrome/lib/filterValidation.js is no longer being used so it can be removed.

Hints for testers

One or more filter errors should be shown when editing filters:

  • Add single/multiple, invalid custom filters through filter composer.
  • Add single, invalid custom filter in Advanced tab of options page.
  • Paste multiple, invalid custom filters in Advanced tab of options page.
  • Add domain to whitelist that results in invalid filter in Whitelisted websites tab of options page. Note that there's currently no way to achieve that without code modifications.

When multiple errors are shown, the error messages should each be in a new line and prefixed with a line number to indicate which filter is invalid.

Attachments (0)

Change History (6)

comment:1 Changed on 02/11/2019 at 03:00:39 PM by greiner

  • Priority changed from Unknown to P3
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 02/11/2019 at 03:04:04 PM by greiner

  • Review URL(s) modified (diff)

comment:3 Changed on 02/11/2019 at 03:38:38 PM by greiner

  • Description modified (diff)

comment:4 Changed on 02/11/2019 at 03:41:43 PM by greiner

  • Description modified (diff)

comment:6 Changed on 08/26/2019 at 02:27:01 PM by abpbot

A commit referencing this issue has landed:
Issue 7273 - Resolve filter parsing error messages in UI

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Note: See TracTickets for help on using tickets.