Changes between Version 2 and Version 3 of Ticket #7273


Ignore:
Timestamp:
02/11/2019 03:38:38 PM (18 months ago)
Author:
greiner
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7273 – Description

    v2 v3  
    44=== What to change === 
    55See [https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/320 ui#320] 
     6 
     7=== Notes for dependency update === 
     8`FilterValidationError.toString()` function in adblockpluschrome/lib/filterValidation.js is no longer being used so it can be removed. 
     9 
     10=== Hints for testers === 
     11One or more filter errors should be shown when editing filters: 
     12- Add single/multiple, invalid custom filters through filter composer. 
     13- Add single, invalid custom filter in Advanced tab of options page. 
     14- Paste multiple, invalid custom filters in Advanced tab of options page. 
     15- Add domain to whitelist that results in invalid filter in Whitelisted websites tab of options page. Note that there's currently no way to achieve that without code modifications. 
     16 
     17When multiple errors are shown, the error messages should each be in a new line and prefixed with a line number to indicate which filter is invalid.