Opened 7 months ago

Closed 7 months ago

#7276 closed change (fixed)

Update adblockpluscore code in adbp2blocklist

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: ashephard, dzhang Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abp2blocklist/merge_requests/5

Description (last modified by kzar)

Background

abp2blocklist contains a modified copy of adblockpluscore/lib/filterClasses.js. It is extremely out of date, and likely to cause problems.

What to change

  • Move filterClasses.js to the adblockpluscore directory.
  • Update filterClasses.js with a more recently version.
  • Bring in the required common.js and coreUtils.js files too.
  • Correct all the require statements to use the correct paths.
  • Update the code to adjust to core changes, for example the regexpSource Filter property was renamed pattern.
  • Remove Unicode handling logic which is no longer necessary.
  • Update the README to explain how to update the adblockpluscore files.
  • Adjust .gitignore and .hgignore to ignore the node_modules directory.

Notes

  • Ensure the unit tests still pass.
  • Ensure the generated rules output is identical, except:
    • Filters erronously containing Unicode characters should be stripped.
    • Core code now simplifies pattern where possible, e.g. stripping trailing .*.
    • Core code now lowercases case insensitive patterns.
  • See related "Track" issue 256.

Change History (10)

comment:1 Changed 7 months ago by kzar

  • Description modified (diff)

comment:2 Changed 7 months ago by kzar

  • Description modified (diff)

comment:3 Changed 7 months ago by kzar

  • Description modified (diff)

comment:4 Changed 7 months ago by kzar

  • Description modified (diff)

comment:5 Changed 7 months ago by kzar

  • Description modified (diff)

comment:6 Changed 7 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 7 months ago by kzar

  • Description modified (diff)

comment:8 Changed 7 months ago by dzhang

  • Priority changed from Unknown to P2
  • Ready set

comment:9 Changed 7 months ago by abpbot

A commit referencing this issue has landed:
Issue 7276 - Update adblockpluscore code

comment:10 Changed 7 months ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.