Opened on 02/12/2019 at 11:13:42 AM

Closed on 02/14/2019 at 10:45:53 AM

#7276 closed change (fixed)

Update adblockpluscore code in adbp2blocklist

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: ashephard, dzhang Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)


abp2blocklist contains a modified copy of adblockpluscore/lib/filterClasses.js. It is extremely out of date, and likely to cause problems.

What to change

  • Move filterClasses.js to the adblockpluscore directory.
  • Update filterClasses.js with a more recently version.
  • Bring in the required common.js and coreUtils.js files too.
  • Correct all the require statements to use the correct paths.
  • Update the code to adjust to core changes, for example the regexpSource Filter property was renamed pattern.
  • Remove Unicode handling logic which is no longer necessary.
  • Update the README to explain how to update the adblockpluscore files.
  • Adjust .gitignore and .hgignore to ignore the node_modules directory.


  • Ensure the unit tests still pass.
  • Ensure the generated rules output is identical, except:
    • Filters erronously containing Unicode characters should be stripped.
    • Core code now simplifies pattern where possible, e.g. stripping trailing .*.
    • Core code now lowercases case insensitive patterns.
  • See related "Track" issue 256.

Attachments (0)

Change History (10)

comment:1 Changed on 02/12/2019 at 11:22:29 AM by kzar

  • Description modified (diff)

comment:2 Changed on 02/12/2019 at 11:34:04 AM by kzar

  • Description modified (diff)

comment:3 Changed on 02/12/2019 at 11:42:52 AM by kzar

  • Description modified (diff)

comment:4 Changed on 02/12/2019 at 11:43:27 AM by kzar

  • Description modified (diff)

comment:5 Changed on 02/12/2019 at 11:57:50 AM by kzar

  • Description modified (diff)

comment:6 Changed on 02/12/2019 at 12:04:00 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 02/12/2019 at 12:14:02 PM by kzar

  • Description modified (diff)

comment:8 Changed on 02/13/2019 at 10:47:07 PM by dzhang

  • Priority changed from Unknown to P2
  • Ready set

comment:9 Changed on 02/14/2019 at 10:44:52 AM by abpbot

A commit referencing this issue has landed:
Issue 7276 - Update adblockpluscore code

comment:10 Changed on 02/14/2019 at 10:45:53 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.