Changes between Version 2 and Version 5 of Ticket #7278


Ignore:
Timestamp:
02/12/2019 02:06:31 PM (20 months ago)
Author:
greiner
Comment:

I've looked through the diff and, apart from the various Edge fixes, the only changes that appear to have not been reapplied were related to adding and removing a single filter.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7278

    • Property Status changed from new to reviewing
    • Property Priority changed from Unknown to P1
    • Property Owner set to greiner
    • Property Ready set
  • Ticket #7278 – Description

    v2 v5  
    2020=== Notes === 
    2121It seems like `FilterStorage` got renamed to `filterStorage`, but not all instances of the name change were made in adblockplusui/messageResponder.js. In this instance, the listener for the "filters.add" message attempts to call `FilterStorage.addFilter`. 
     22 
     23=== Hints for testers === 
     24In Whitelisted websites tab in options page: 
     25- Adding a domain to the list should work 
     26- Removing a domain from the list should work 
  • Ticket #7278 – Review URL(s)

    v2 v5  
     1https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/220