Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#7279 closed change (fixed)

Update adblockplusui dependency to 78fd3c96c712 (release-2018-5.-6)

Reported by: greiner Assignee: kzar
Priority: P1 Milestone: Adblock-Plus-3.5-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar, wspee, Ross, rscott, ukacar Blocked By: #7278
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/38

Description (last modified by greiner)

Background

This imports the following changes:


What to change

Change adblockplusui dependency to hg:78fd3c96c712 git:17697d3.

Hints for testers

This should fix the regression whereby domains added to the "Whitelisted websites" section of the options page were never really added. See #7278 for more details.

Change History (10)

comment:1 Changed 9 months ago by greiner

  • Description modified (diff)

comment:2 Changed 9 months ago by greiner

  • Cc sebastian kzar wspee added

comment:3 Changed 9 months ago by kzar

  • Description modified (diff)
  • Priority changed from Unknown to P1

comment:4 Changed 9 months ago by greiner

  • Description modified (diff)
  • Summary changed from Update adblockplusui dependency to TBD (release-2018-5.-6) to Update adblockplusui dependency to 78fd3c96c712 (release-2018-5.-6)

Added hashes to ticket description.

comment:5 Changed 9 months ago by kzar

  • Owner set to kzar
  • Ready set

comment:6 Changed 9 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 7279 - Update adblockplusui dependency to 78fd3c96c712

comment:8 Changed 9 months ago by kzar

  • Cc Ross rscott ukacar added
  • Milestone set to Adblock-Plus-3.5-for-Chrome-Opera-Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed

Heads up, this fix for the whitelisted domains tab of the options page (#7278) is being included in the release now as well.

comment:9 Changed 9 months ago by ukacar

  • Verified working set

comment:10 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 7279 - Update adblockplusui dependency to 78fd3c96c712

Note: See TracTickets for help on using tickets.