Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#7282 closed change (fixed)

Skip online-only testcases when running testpages.adblockplus.org locally

Reported by: Ross Assignee: Ross
Priority: P3 Milestone: Adblock-Plus-for-Chrome-Opera-Firefox-next
Module: Automation Keywords:
Cc: kzar, sebastian, tlucas Blocked By:
Blocking: #7164 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/40

Description (last modified by Ross)

Background

We would like to add $sitekey testcases to testpages.adblockplus.org. These test cases won't work when using a local copy of the test pages, since an additional web server to generate the sitekey header is required.

We're going to add an online class to the links to testcase pages which we would only expect to work online. Let's skip those pages if a flag is set.

What to change

Add logic to adblockpluschrome/test/wrappers/pages.js that skips any test case page link with the online class if the SKIP_ONLINE_TESTS variable is true.

Change History (13)

comment:1 Changed 8 months ago by Ross

My first thoughts were to add a flag/class to the main menu page links to skip them, however Dave mentioned adding a class to testcase-container on the pages themselves instead which allows for more targetted skipping.

comment:2 follow-up: Changed 8 months ago by kzar

  • Cc tlucas added
  • Description modified (diff)
  • Priority changed from P2 to Unknown
  • Summary changed from Add logic to skip test cases not compatible with locally run test pages to Skip online-only testcases when running testpages.adblockplus.org locally

Are you OK to triage this Tristan? (I'm happy with the proposed plan, I already discussed it with Ross in IRC.)

comment:3 Changed 8 months ago by tlucas

  • Priority changed from Unknown to P3
  • Ready set

comment:4 in reply to: ↑ 2 Changed 8 months ago by tlucas

Replying to kzar:

Are you OK to triage this Tristan? (I'm happy with the proposed plan, I already discussed it with Ross in IRC.)

Sure, although imho this should be P3 - Do you agree?

comment:5 Changed 8 months ago by Ross

We might have to apply this at the page level instead of the testcase-container level. This is because the link to the sitekey page will be using the special frame (/sitekey-frame#/exceptions/sitekey) and when run locally, this does not load a page with a testcase-container to check for the flag. Thoughts?

comment:6 Changed 8 months ago by kzar

  • Description modified (diff)

Yes, that's is a good point Ross. I didn't consider that. I guess the link to the page should have a class, so we can skip the whole page instead. I've updated the description again, what do you think?

Sure, although imho this should be P3 - Do you agree?

Sure, fine by me. Thanks.

comment:7 Changed 8 months ago by kzar

  • Description modified (diff)

comment:8 Changed 8 months ago by Ross

  • Description modified (diff)

comment:9 Changed 8 months ago by Ross

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:11 Changed 8 months ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed 8 months ago by kzar

  • Owner set to Ross

comment:13 Changed 8 months ago by kzar

  • Blocking 7164 added
Note: See TracTickets for help on using tickets.