Changes between Version 2 and Version 6 of Ticket #7282


Ignore:
Timestamp:
02/14/2019 10:38:29 AM (18 months ago)
Author:
kzar
Comment:

Yes, that's is a good point Ross. I didn't consider that. I guess the link to the page should have a class, so we can skip the whole page instead. I've updated the description again, what do you think?

Sure, although imho this should be P3 - Do you agree?

Sure, fine by me. Thanks.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7282

    • Property Priority changed from Unknown to P3
    • Property Ready set
  • Ticket #7282 – Description

    v2 v6  
    22We would like to add `$sitekey` testcases to testpages.adblockplus.org. These test cases won't work when using a local copy of the test pages, since an additional web server to generate the sitekey headers is required. 
    33 
    4 We're going to add an `online-only` class to the `testcase-container` divs which we only expect to work online. Let's skip those test cases unless we're using the default testpages.adblockplus.org URL. 
     4We're going to add an `online-only` class to the links to testcase pages which we would only expect to work online. Let's skip those pages unless we're using the default testpages.adblockplus.org URL. 
    55 
    66=== What to change === 
    7 Add logic to `adblockpluschrome/test/wrappers/pages.js` that skips any test case wit hthe `online-only` class, unless the `TEST_PAGES_URL` variable is the default "https://testpages.adblockplus.org/en/". 
     7Add logic to `adblockpluschrome/test/wrappers/pages.js` that skips any test case page link with the `online-only` class, unless the `TEST_PAGES_URL` variable is the default "https://testpages.adblockplus.org/en/".