Changes between Version 7 and Version 8 of Ticket #7282


Ignore:
Timestamp:
02/14/2019 03:24:40 PM (18 months ago)
Author:
Ross
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7282 – Description

    v7 v8  
    22We would like to add `$sitekey` testcases to testpages.adblockplus.org. These test cases won't work when using a local copy of the test pages, since an additional web server to generate the sitekey header is required. 
    33 
    4 We're going to add an `online-only` class to the links to testcase pages which we would only expect to work online. Let's skip those pages unless we're using the default testpages.adblockplus.org URL. 
     4We're going to add an `online` class to the links to testcase pages which we would only expect to work online. Let's skip those pages if a flag is set. 
    55 
    66=== What to change === 
    7 Add logic to `adblockpluschrome/test/wrappers/pages.js` that skips any test case page link with the `online-only` class, unless the `TEST_PAGES_URL` variable is the default "https://testpages.adblockplus.org/en/". 
     7Add logic to `adblockpluschrome/test/wrappers/pages.js` that skips any test case page link with the `online` class if the `SKIP_ONLINE_TESTS` variable is `true`.