Opened 10 months ago

Closed 10 months ago

Last modified 4 months ago

#7289 closed change (fixed)

Update adblockpluscore dependency to b86a01e2db02

Reported by: tlucas Assignee:
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/39

Description (last modified by tlucas)

Background

We landed a change in adblockpluscore which makes downloading a Chromium version more reliable, when a matching package could not be found. We now want to use this in ablockpluschrome

Included changes in adblockpluscore

The list of changes imported by this is:


b86a01e2db02 Noissue - try fetching lower chromium revisions on failure Tristan Lucas
f1d6272c6b60 Noissue - Abstract hostname normalization Manish Jethani

What to change

Update the adblockpluscore dependency to:

mercurial git
b86a01e2db02 6e0ad85

Hints for testers

Please see #7267 and #7268 for actual changes in the extension.

Change History (5)

comment:1 Changed 10 months ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 10 months ago by tlucas

  • Description modified (diff)
  • Summary changed from Update adblockpluscore dependency to b24f329270f3 to Update adblockpluscore dependency to b86a01e2db02

comment:3 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 7289 - Update adblockpluscore to b86a01e2db02 / 6e0ad85

comment:4 Changed 10 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 4 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Child tickets working as described.

ABP 0.9.15.2339
Microsoft Edge 44.17763.1.0 / Windows 10 1809

ABP 3.5.2.2340
Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809
Firefox Mobile 68.0 / Android 7.2.2

Note: See TracTickets for help on using tickets.