Opened 10 months ago

Closed 9 months ago

Last modified 3 months ago

#7293 closed change (fixed)

Remove "+" prefix from translatable strings

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/225

Description (last modified by greiner)

Background

See ui#334

What to change

See ui#334

Hints for testers

The following buttons should have a text that's preceded by a "+" character and separated by a space:

Mobile options page

  • "Add a language" button in General tab
  • "Add a new filter list" button in Advanced tab

Desktop options page

  • "Add a filter list" button
  • "Add a custom filter list" button in dialog that appears when clicking on "Add a filter list" button

The position of the "+" and space should be inverted for RTL locales.

Hints for translators

Remove + prefix from the following strings:

  • mops_filterlist_add
  • mops_filterlist_add_url
  • options_filterList_add
  • options_language_add

Change History (5)

comment:1 Changed 10 months ago by greiner

  • Description modified (diff)

Added hints for testers section.

comment:2 Changed 10 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 10 months ago by greiner

  • Description modified (diff)

comment:4 Changed 9 months ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 months ago by abpbot

A commit referencing this issue has landed:
Issue 7293 - Moved decorative prefix out of translatable strings

Note: See TracTickets for help on using tickets.