Opened 8 months ago

Closed 8 months ago

Last modified 6 days ago

#7295 closed change (fixed)

Add non-active filters to blocking group

Reported by: mjethani Assignee: mjethani
Priority: P3 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/30009567/

Description (last modified by mjethani)

Background

While going through the code, I came across this line in lib/subscriptionClasses.js:

if (!(filter instanceof ActiveFilter) && type == "blacklist")

Clearly the intention here is that comments and invalid filters should go into the blocking group. It is written as "blacklist" in error. This explains #6858. Now we can fix this by replacing it with "blocking". Since the default group for a special subscription is blocking, this should fix #6858 and ensure that comments always end up in the subscription for blocking filters.

What to change

Replace "blacklist" with "blocking" in lib/subscriptionClasses.js. Update tests.

Hints for testers

Add a comment filter (e.g. !foo), reload the extension, and see that it is still there. Try the same with a blocking filter (e.g. foo) and element hiding filter (e.g. ##.foo).

Change History (6)

comment:1 Changed 8 months ago by mjethani

  • Owner set to mjethani
  • Review URL(s) modified (diff)

comment:2 Changed 8 months ago by mjethani

  • Status changed from new to reviewing

comment:3 Changed 8 months ago by abpbot

A commit referencing this issue has landed:
Issue 7295 - Add non-active filters to blocking group

comment:4 Changed 8 months ago by mjethani

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 months ago by ukacar

  • Verified working set

comment:6 Changed 3 months ago by jha2125

spam

Last edited 6 days ago by kzar (previous) (diff)
Note: See TracTickets for help on using tickets.