Opened 10 months ago

Last modified 2 months ago

#7295 closed change

Add non-active filters to blocking group — at Version 1

Reported by: mjethani Assignee: mjethani
Priority: P3 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/30009567/

Description

Background

While going through the code, I came across this line in lib/subscriptionClasses.js:

if (!(filter instanceof ActiveFilter) && type == "blacklist")

Clearly the intention here is that comments and invalid filters should go into the blocking group. It is written as "blacklist" in error. This explains #6858. Now we can fix this by replacing it with "blocking". Since the default group for a special subscription is blocking, this should fix #6858 and ensure that comments always end up in the subscription for blocking filters.

What to change

Replace "blacklist" with "blocking" in lib/subscriptionClasses.js. Update tests.

Change History (1)

comment:1 Changed 10 months ago by mjethani

  • Owner set to mjethani
  • Review URL(s) modified (diff)
Note: See TracTickets for help on using tickets.