Opened 7 months ago

Closed 7 months ago

Last modified 8 weeks ago

#7311 closed change (fixed)

Fix performance regression introduced in changeset 0da36169b1a4 (#7267)

Reported by: mjethani Assignee: mjethani
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/30018555/

Description (last modified by mjethani)

Background

After changset 0da36169b1a4 the _checkEntryMatch() function takes longer. It is not clear why this is, but it is possibly because of the additional lines of code that cause the function to be deoptimized on V8.

What to change

Split _checkEntryMatchByDomain() into two smaller functions for the Filter and Map cases.

Hints for testers

Same as #7265.

Change History (6)

comment:1 Changed 7 months ago by mjethani

  • Blocking 7000 removed

comment:2 Changed 7 months ago by abpbot

A commit referencing this issue has landed:
Issue 7311 - Split _checkEntryMatchByDomain()

comment:3 Changed 7 months ago by mjethani

  • Description modified (diff)

comment:4 Changed 7 months ago by mjethani

  • Description modified (diff)
  • Ready set

comment:5 Changed 7 months ago by mjethani

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

comment:6 Changed 8 weeks ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Working as described in #7265.

ABP 0.9.15.2340
Microsoft Edge 44.17763.1.0 / Windows 10 1809

ABP 3.5.2.2340
Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809
Firefox Mobile 68.0 / Android 7.2.2

Note: See TracTickets for help on using tickets.