Changes between Initial Version and Version 3 of Ticket #7311


Ignore:
Timestamp:
03/01/2019 06:30:43 AM (8 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7311

    • Property Blocking changed from 7000 to
  • Ticket #7311 – Description

    initial v3  
    11=== Background === 
    2 After [https://hg.adblockplus.org/adblockpluscore/rev/0da36169b1a4#l1.143 changset 0da36169b1a4] the `checkEntryMatch()` function takes longer. It is not clear why this is, but it is possibly because of the [https://hg.adblockplus.org/adblockpluscore/rev/0da36169b1a4#l1.143 additional lines of code] that cause the function to be deoptimized on V8. 
     2After [https://hg.adblockplus.org/adblockpluscore/rev/0da36169b1a4#l1.143 changset 0da36169b1a4] the `_checkEntryMatch()` function takes longer. It is not clear why this is, but it is possibly because of the [https://hg.adblockplus.org/adblockpluscore/rev/0da36169b1a4#l1.143 additional lines of code] that cause the function to be deoptimized on V8. 
    33 
    44=== What to change === 
    5 To be determined. 
     5Split `_checkEntryMatchByDomain()` into two smaller functions for the `Filter` and `Map` cases.