Opened 4 months ago

Last modified 4 months ago

#7315 reviewing change

Move whitelisting to frame on sitekey test page

Reported by: Ross Assignee:
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/testpages.adblockplus.org/merge_requests/8

Description (last modified by Ross)

Background

The sitekey test page works, however from just using the test page subscription it's difficult to actually tell that (because the page with no filters and the page with working filters will look the same).

What to change

Sitekey page:

  • Add an element on the page to hide (.testcase-sitekey-eh)
  • Change the image to not take up so much space.
  • Add a frame that uses /sitekey-frame# to load the testcasefiles/sitekey/frame.html.
  • Update filters.

Menu:

  • Update the link in the main test case menu (exceptions/sitekey)

Change History (5)

comment:1 Changed 4 months ago by Ross

  • Summary changed from Add frame to sitekey test page to Move whitelisting to frame on sitekey test page

comment:2 Changed 4 months ago by Ross

  • Description modified (diff)

comment:3 Changed 4 months ago by Ross

  • Component changed from Unknown to Websites
  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed 4 months ago by Ross

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 4 months ago by abpbot

A commit referencing this issue has landed:
Issue 7315 - Add missing styles to frame element

Note: See TracTickets for help on using tickets.