Changes between Version 3 and Version 5 of Ticket #7321


Ignore:
Timestamp:
03/02/2019 12:43:08 PM (8 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7321

    • Property Status changed from new to closed
    • Property Resolution changed from to fixed
  • Ticket #7321 – Description

    v3 v5  
    66=== What to change === 
    77In the `RegExpFilter` constructor in `lib/filterClasses.js`, convert the pattern to lower case unless the `$match-case` flag is set. In `matchesLocation()`, lower-case the request URL first thing unless the `$match-case` flag is set. 
     8 
     9=== Hints for testers === 
     10See that regular expression filters and filters with patterns containing special characters (esp. somewhere in the middle) work correctly, with and without the `$match-case` option. The filters `/FoO/` and `FoO^BaR` should both block the URL `https://example.com/foo/bar` (each one on its own, not together). If the `$match-case` option is added to these filters, they should ''not'' block the URL. If the `$~match-case` option is added instead, they should block the URL.